Agreed. Not only that, but we also have java.cleanup.actionsOnSave which is LS supported, so it will work for clients other than VS Code. If you just add to https://github.com/eclipse/eclipse.jdt.ls/blob/702d59eb54f6bdd5e8bf1efbec3db2856b3a6339/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/cleanup/CleanUpRegistry.java#L42-L52 and are able to get organize imports to support the https://github.com/eclipse/eclipse.jdt.ls/blob/master/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/cleanup/ISimpleCleanUp.java interface.

@rgrunber do you mean we could add the organize imports support into java.cleanup.actionsOnSave?

• For VS Code, i suggest we can find a way to also integrate java.cleanup.actionsOnSave into editor.codeActionsOnSave, maybe a way is to make clean ups as code actions so that they can have corresponding code action ids. (I'm not familiar with this implementation, please correct me if I'm wrong :))
• For jdtls and other clients, since other clients might not have editor.codeActionsOnSave, we can also keep current implementation for the compatiblity.

Yup, something as simple as rgrunber/eclipse.jdt.ls@2497722 seems to work. You can then just set "java.cleanup.actionsOnSave": ["organizeImports"] in VS Code settings (it will complain because it isn't a known value but the LS will respect it).

We could definitely look at ways to integrate with editor.codeActionsOnSave since that works based on the code action id/kind and opens up possibilities to even more save actions. The main downside is the setting is only for VS Code.